Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24071 )
Change subject: IMPALA-14755:(part 1) Implement Puffin Blob reader and File writer ...................................................................... Patch Set 3: (8 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24071/3/be/src/exec/output-partition.h File be/src/exec/output-partition.h: http://gerrit.cloudera.org:8080/#/c/24071/3/be/src/exec/output-partition.h@37 PS3, Line 37: /// Tracks both old deletion vectors (that were merged and should be removed from metadata) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24071/3/be/src/exec/output-partition.h@128 PS3, Line 128: std::unique_ptr<PuffinWriteResult> puffin_result = std::make_unique<PuffinWriteResult>(); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24071/3/be/src/exec/puffin/puffin-writer.h File be/src/exec/puffin/puffin-writer.h: http://gerrit.cloudera.org:8080/#/c/24071/3/be/src/exec/puffin/puffin-writer.h@125 PS3, Line 125: /// This is populated by AppendRows() and converted to deletion vector blobs in Finalize() line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24071/3/be/src/exec/puffin/puffin-writer.cc File be/src/exec/puffin/puffin-writer.cc: http://gerrit.cloudera.org:8080/#/c/24071/3/be/src/exec/puffin/puffin-writer.cc@275 PS3, Line 275: // Note: path will be set later in createIcebergDataFileString() when final path is known line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24071/3/common/fbs/IcebergObjects.fbs File common/fbs/IcebergObjects.fbs: PS3: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new fields can be added and should be added at the end of a table definition. https://flatbuffers.dev/flatbuffers_guide_writing_schema.html http://gerrit.cloudera.org:8080/#/c/24071/3/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/24071/3/common/thrift/CatalogObjects.thrift@679 PS3, Line 679: 10: optional map<string, Types.TIcebergDeletionVector> data_path_hash_to_dv Changing type of field 'data_path_hash_to_dv' from map<THash128,TIcebergDeletionVector> to map<string,Types.TIcebergDeletionVector> in TIcebergContentFileStore might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/24071/3/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: http://gerrit.cloudera.org:8080/#/c/24071/3/common/thrift/CatalogService.thrift@243 PS3, Line 243: // Deletion vectors to add to the table metadata, encoded as FlatBuffer FbIcebergDeletionVector. line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/24071/3/common/thrift/CatalogService.thrift@247 PS3, Line 247: // Deletion vectors to remove from the table metadata, encoded as FlatBuffer FbIcebergDeletionVector. line too long (103 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I068a071f9db907064ccec8568db5234863eb4587 Gerrit-Change-Number: 24071 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2026 15:14:20 +0000 Gerrit-HasComments: Yes
