[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/23789 )
Change subject: IMPALA-14535: Improve wait for HMS events sync with hierarchical event processing ...................................................................... Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/23789/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/23789/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1996 PS7, Line 1996: LOG.info("Waiting for last dispatched event ({}) to reach latest event ({})", > nit: Let's also log the latestEventId here. Done http://gerrit.cloudera.org:8080/#/c/23789/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@2023 PS7, Line 2023: LOG.info("Synced database: {}", dbName); > nit: let's mention it's a database, e.g. "Synced database: default", "Synce Done http://gerrit.cloudera.org:8080/#/c/23789/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@2050 PS7, Line 2050: boolean isProcessed = eventExecutorService_.isProcessed(dbName, latestEventId); > nit: let's mention it's a database Done http://gerrit.cloudera.org:8080/#/c/23789/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@2060 PS7, Line 2060: tableName, latestEventId); > nit: let's mention it's a table, e.g. "Synced table: functional.alltypes". Done http://gerrit.cloudera.org:8080/#/c/23789/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/23789/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@2096 PS8, Line 2096: LOG.info("All required databases and tables are synced up to event ({})", : latestEventId); > I think it's possible that the greatest synced event id doesn't reach lates Done -- To view, visit http://gerrit.cloudera.org:8080/23789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55cea4cb8e04860202e56e1b1bf2596613b4946c Gerrit-Change-Number: 23789 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 11 Mar 2026 09:49:25 +0000 Gerrit-HasComments: Yes
