Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22217 )
Change subject: WIP IMPALA-13475 ...................................................................... Patch Set 5: (5 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22217/5/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/22217/5/be/src/runtime/krpc-data-stream-recvr.cc@526 PS5, Line 526: if (!deferred_rpcs_.empty() || !pending_deferred_rpcs_.empty() || !CanEnqueue(batch_size, false)) { line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/22217/5/be/src/runtime/krpc-data-stream-recvr.cc@528 PS5, Line 528: auto payload = make_unique<TransmitDataCtx>(request, response, rpc_context, batch_size); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22217/5/be/src/runtime/krpc-data-stream-recvr.cc@603 PS5, Line 603: Status KrpcDataStreamRecvr::SenderQueue::GetBatchSize(const TransmitDataRequestPB* request, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22217/5/be/src/runtime/krpc-data-stream-recvr.cc@739 PS5, Line 739: if (pending_deferred_rpcs_.empty()) has_pending_deferred_rpcs_start_time_ns_ = MonotonicNanos(); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22217/5/be/src/runtime/krpc-data-stream-recvr.cc@745 PS5, Line 745: DCHECK(!batch_queue_.empty() || !pending_deferred_rpcs_.empty() || num_pending_enqueue_ > 0); line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d8e2b07a19e4d30210d7903c01e75fba632a1de Gerrit-Change-Number: 22217 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sat, 14 Mar 2026 08:10:18 +0000 Gerrit-HasComments: Yes
