Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/24093 )
Change subject: IMPALA-14592: Enable OPTIMIZE for Iceberg V3 tables ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24093/1/fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java File fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java: http://gerrit.cloudera.org:8080/#/c/24093/1/fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java@282 PS1, Line 282: } > Yeah, we have similar auxiliary methods in IcebergUtil (e.g. getIcebergPart Good idea http://gerrit.cloudera.org:8080/#/c/24093/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-optimize.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-optimize.test: http://gerrit.cloudera.org:8080/#/c/24093/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-optimize.test@25 PS1, Line 25: SELECT _file_row_id, _file_last_updated_sequence_number, * FROM optimize_nopart; > The compacted data files have new firs-row-id and data-sequence-numbers whi Oh, I see why. I am fine with both versions, thanks. -- To view, visit http://gerrit.cloudera.org:8080/24093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c3cc4b9aaa46e494e1aa4583c1a6aafecad48de Gerrit-Change-Number: 24093 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 19 Mar 2026 14:19:42 +0000 Gerrit-HasComments: Yes
