Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24095 )
Change subject: IMPALA-7618: Accept reversed comparators (> / >=) in range partition bounds ...................................................................... Patch Set 1: (3 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/24095/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24095/1//COMMIT_MSG@21 PS1, Line 21: Co-Authored-By: Claude Opus 4.6 <[email protected]> nit: Convention is: Generated-by: Claude Opus 4.6 See https://www.apache.org/legal/generative-tooling.html http://gerrit.cloudera.org:8080/#/c/24095/1/fe/src/main/java/org/apache/impala/analysis/RangeBound.java File fe/src/main/java/org/apache/impala/analysis/RangeBound.java: http://gerrit.cloudera.org:8080/#/c/24095/1/fe/src/main/java/org/apache/impala/analysis/RangeBound.java@36 PS1, Line 36: boolean inclusive, boolean reversed I think the could would become cleaner at a lot of places if you'd introduced a single enum: - LESS_THAN - LESS_EQUAL - GREATER_THAN - GREATER_EQUAL http://gerrit.cloudera.org:8080/#/c/24095/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java: http://gerrit.cloudera.org:8080/#/c/24095/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@195 PS1, Line 195: (partition values >= 1, partition 4 > values Is it possible to add test for partition 4 > values >= 1 -- To view, visit http://gerrit.cloudera.org:8080/24095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia12668537bfc72cc9399a60f68ca7608422b35c2 Gerrit-Change-Number: 24095 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 20 Mar 2026 12:38:48 +0000 Gerrit-HasComments: Yes
