Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24062 )
Change subject: IMPALA-14116: Skip NULL in an IN-list against a column of an ORC table ...................................................................... Patch Set 10: (1 comment) I added a TODO in hdfs-orc-scanner.cc in patch set 10 (compared to patch set 9). Let me know if there are additional suggestions. Thanks! http://gerrit.cloudera.org:8080/#/c/24062/8/be/src/exec/orc/hdfs-orc-scanner.cc File be/src/exec/orc/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/24062/8/be/src/exec/orc/hdfs-orc-scanner.cc@1213 PS8, Line 1213: // TODO: We should handle memory allocation failure correctly in IMPALA-10882. > Nice catch! This might silently push down a wrong predicate. However, this Thanks for the confirmation Quanlong! I will add a TODO here in the next patch. -- To view, visit http://gerrit.cloudera.org:8080/24062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id62a631e5aa97132afbe0b184d427ad6bc1a4ad0 Gerrit-Change-Number: 24062 Gerrit-PatchSet: 10 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 24 Mar 2026 01:50:17 +0000 Gerrit-HasComments: Yes
