Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24079 )
Change subject: IMPALA-14820: Calcite Planner: Memory allocations are too high ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24079/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/24079/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@103 PS3, Line 103: if (!(relNode instanceof Sort)) { nit: can we add a comment mentioning that Calcite uses the Sort RelNode for "order by", "limit" and "offset"? http://gerrit.cloudera.org:8080/#/c/24079/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@108 PS3, Line 108: (BigDecimal) Will this cast always succeed? -- To view, visit http://gerrit.cloudera.org:8080/24079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e84061b65f115ea65a9d2c2d40173843040ca0c Gerrit-Change-Number: 24079 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 25 Mar 2026 09:53:17 +0000 Gerrit-HasComments: Yes
