Adam Holley has uploaded a new patch set (#2). (
http://gerrit.cloudera.org:8080/10784 )
Change subject: IMPALA-3956 - Impala shell should ignore variables in comments
......................................................................
IMPALA-3956 - Impala shell should ignore variables in comments
This patches fixes an issue where variables that appeared in
comments were being parsed.
> /* ${abc} */ help;
Before - Unknown sustitution syntax (ABC) error
After - Shows help correctly
Testing:
- Added shell tests
- Ran end-to-end shell tests.
Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 65 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/10784/2
--
To view, visit http://gerrit.cloudera.org:8080/10784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e442e169d512daf80c86606528300ce4e6f371c
Gerrit-Change-Number: 10784
Gerrit-PatchSet: 2
Gerrit-Owner: Adam Holley <ahol...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
