Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24205 )
Change subject: IMPALA-14884: Implement SHOW CURRENT GROUPS statement ...................................................................... Patch Set 7: (2 comments) Some high level comments - the code looks good to me, but I didn't look that deep. http://gerrit.cloudera.org:8080/#/c/24205/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24205/7//COMMIT_MSG@9 PS7, Line 9: SHOW CURRENT GROUPS Is this syntax used by some other database or it is something new? https://docs.databricks.com/aws/en/sql/language-manual/sql-ref-syntax-aux-show-groups I found something similar in databricks SQL: SHOW GROUPS WITH USER <user> Another alternative solution I can imagine creating a function current_groups() similar to current_user(). For diagnostic purposes getting a comma separated list also seems ok to me. (don't know how expensive is to get the group list - doing this for each query like user name may be too expensive) I don't have problems with syntax SHOW CURRENT GROUPS, but it could be noted in commit message that this is non-standard and why you chose this solution. http://gerrit.cloudera.org:8080/#/c/24205/7//COMMIT_MSG@15 PS7, Line 15: This also slightly extends how 'struct_field_def' can grow via 'word' so : that we could still support the following statement afterward. : : CREATE TABLE t (i STRUCT<groups:INT>); Where is this part in the code? I saw neither tests or parser changes around complex types. It could be mentioned that GROUPS is already a reserved word (see sql-scanner.flex // Add SQL:2016 reserved words) -- To view, visit http://gerrit.cloudera.org:8080/24205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d65c6d038e9bb2d56c6c2510eaf52a8c27965c8 Gerrit-Change-Number: 24205 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 05 May 2026 11:41:21 +0000 Gerrit-HasComments: Yes
