Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10811 )
Change subject: IMPALA-7207: make Coordinator::exec_state_ an atomic enum ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10811/2/be/src/runtime/coordinator.h File be/src/runtime/coordinator.h: http://gerrit.cloudera.org:8080/#/c/10811/2/be/src/runtime/coordinator.h@278 PS2, Line 278: exec-state_ exec_state_ http://gerrit.cloudera.org:8080/#/c/10811/2/be/src/runtime/coordinator.h@279 PS2, Line 279: both : // fields. does this mean reading both fields atomically? Wording is a little unclear. -- To view, visit http://gerrit.cloudera.org:8080/10811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6c5d5c6ccfdfd533cd0607aab6f554e664b90ac Gerrit-Change-Number: 10811 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Jun 2018 18:52:38 +0000 Gerrit-HasComments: Yes
