Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10815 )
Change subject: IMPALA-7205: Respond to ReportExecStatus() RPC with CANCELLED if query execution has terminated ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10815/1/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/10815/1/be/src/runtime/coordinator-backend-state.cc@336 PS1, Line 336: const TQueryCtx& query_ctx This unfortunately makes the code look a little less readable. Since we require the TQueryCtx in multiple places in BackendState, how about storing the TQueryCtx at BackendState object construction time? Or alternatively, store a pointer to Coordinator, and get it from Coodrdinator::query_ctx() ? -- To view, visit http://gerrit.cloudera.org:8080/10815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bb2c26edace89853f14a329f891d1f9a065a991 Gerrit-Change-Number: 10815 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 26 Jun 2018 20:06:07 +0000 Gerrit-HasComments: Yes
