Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10823 )
Change subject: IMPALA-7190: Remove unsupported format writer support ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10823/1/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: http://gerrit.cloudera.org:8080/#/c/10823/1/be/src/exec/hdfs-table-sink.cc@484 PS1, Line 484: } presumably we do this error checking at runtime rather than analysis so that we can insert into new partitions of a table that has old partitions in a format that's supported for reading but not writing. Do we have a test case to demonstrate that this works? i.e. the case that shows we don't hit these errors when inserting to a table that has these formats in other partitions. -- To view, visit http://gerrit.cloudera.org:8080/10823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I821dc7495a901f1658daa500daf3791b386c7185 Gerrit-Change-Number: 10823 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Jun 2018 17:28:04 +0000 Gerrit-HasComments: Yes
