Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10841 )
Change subject: IMPALA-6802 (part 6): Clean up authorization tests ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/10841/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/10841/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2081 PS3, Line 2081: private static String dropFunctionError(String object) { Don't we need a similar handler for function use error? -- To view, visit http://gerrit.cloudera.org:8080/10841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 Gerrit-Change-Number: 10841 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Jun 2018 21:29:01 +0000 Gerrit-HasComments: Yes
