Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10829 )
Change subject: [DOCS] Clarification on admission control and DDL statements ...................................................................... Patch Set 2: (6 comments) Removed the confusing examples and paragraphs. Added what are affected by admission control at the top. http://gerrit.cloudera.org:8080/#/c/10829/2/docs/topics/impala_admission.xml File docs/topics/impala_admission.xml: http://gerrit.cloudera.org:8080/#/c/10829/2/docs/topics/impala_admission.xml@822 PS2, Line 822: Most write operations in Impala are not resource-intensive, but > This bit about "most write operations" feels very tangential, not sure how Removed http://gerrit.cloudera.org:8080/#/c/10829/2/docs/topics/impala_admission.xml@847 PS2, Line 847: With or without admission control, all queries submitted in a session > Unfortunately this isn't even true - it depends on the driver, the APIs giv Removed http://gerrit.cloudera.org:8080/#/c/10829/2/docs/topics/impala_admission.xml@853 PS2, Line 853: Except for the <codeph>CREATE TABLE AS SELECT</codeph> statements, > And compute stats Done http://gerrit.cloudera.org:8080/#/c/10829/2/docs/topics/impala_admission.xml@855 PS2, Line 855: those DDL statements > which does "those DDL statements" mean? It's a little unclear. I think it's Done http://gerrit.cloudera.org:8080/#/c/10829/2/docs/topics/impala_admission.xml@855 PS2, Line 855: for serial execution > remove "for serial execution" - AC doesn't guarantee anything whether state Removed http://gerrit.cloudera.org:8080/#/c/10829/2/docs/topics/impala_admission.xml@859 PS2, Line 859: <codeblock>-- This query is queued by admission control to avoid out-of-memory at times of heavy load. : SELECT * FROM huge_table JOIN enormous_table USING (id); : : -- This subsequent statement in the same session is also queued, but for serial execution and : -- not for admission control, until the previous statement completes. : DROP TABLE huge_table; : </codeblock> > I think this example is still misleading. I'm not sure what it's demonstrat Done -- To view, visit http://gerrit.cloudera.org:8080/10829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e3e82bd34e88e7a13de1864aeb97f01023bc715 Gerrit-Change-Number: 10829 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Balazs Jeszenszky <jes...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Jun 2018 21:54:29 +0000 Gerrit-HasComments: Yes
