Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 )
Change subject: IMPALA-7163: Implement a state machine for the QueryState class ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10813/2/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/10813/2/be/src/runtime/query-state.cc@209 PS2, Line 209: {BackendExecState::INITIALIZED, "INITIALIZED"}, : {BackendExecState::STARTED, "STARTED"}, : {BackendExecState::PREPARED, "PREPARED"}, : {BackendExecState::OPENED, "OPENED"}, : {BackendExecState::FINISHED, "FINISHED"}, : {BackendExecState::CANCELLED, "CANCELLED"}, : {BackendExecState::ERROR, "ERROR"}}; : return exec_state_to_str.at(state); As discussed offline, it seems we can simplify this a bit by merging INITIALIZED and STARTED states and get rid of OPENED state altogether. -- To view, visit http://gerrit.cloudera.org:8080/10813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec5670a7db83ecae4656d7bb2ea372d3767ba7fe Gerrit-Change-Number: 10813 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Jun 2018 22:08:12 +0000 Gerrit-HasComments: Yes
