Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24392 )
Change subject: IMPALA-15067: Add VariantValue and basic decoding functions ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/24392/3/be/src/runtime/variant-value.h File be/src/runtime/variant-value.h: http://gerrit.cloudera.org:8080/#/c/24392/3/be/src/runtime/variant-value.h@184 PS3, Line 184: const char* name, int name_len nit: it could be a std::string_view http://gerrit.cloudera.org:8080/#/c/24392/3/be/src/runtime/variant-value.cc File be/src/runtime/variant-value.cc: http://gerrit.cloudera.org:8080/#/c/24392/3/be/src/runtime/variant-value.cc@115 PS3, Line 115: for (int i = 0; i < size; ++i) { Similarly to L72, it could be unrolled http://gerrit.cloudera.org:8080/#/c/24392/3/be/src/util/variant-util-test.cc File be/src/util/variant-util-test.cc: http://gerrit.cloudera.org:8080/#/c/24392/3/be/src/util/variant-util-test.cc@260 PS3, Line 260: TEST(VariantUtilTest, PathNavigation) { Please add a test for negative cases like empty brackets "$.arr[]", field not found, OOB lookup, overflow check, consecutive dots "..", "$.". http://gerrit.cloudera.org:8080/#/c/24392/3/be/src/util/variant-util-test.cc@288 PS3, Line 288: VariantMetadata metadata; nit: indent -- To view, visit http://gerrit.cloudera.org:8080/24392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I904618570e8c21d099c9a96b496d85e9246483de Gerrit-Change-Number: 24392 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 15 Jun 2026 09:28:40 +0000 Gerrit-HasComments: Yes
