Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 )
Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down ...................................................................... Patch Set 1: > How does your change interact with the Breakpad integration? > SIGSEGV and SIGABRT are also handled by the Breakpad signal handler > (https://chromium.googlesource.com/breakpad/breakpad/+/master/src/client/linux/handler/exception_handler.cc#115). > > It should have a test, possibly in the custom-cluster-tests folder, > to validate that Impala does the expected for each signal it could > receive. > > An alternative approach could be to print the received signal into > the logs when writing a minidump. I'm resorting to default handlers after the message has been dumped but anyways I'll test it with breakpad and see if it affects the core/minidump creation -- To view, visit http://gerrit.cloudera.org:8080/10847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id20da9e30440b7348557beccb8a0da14775fcc29 Gerrit-Change-Number: 10847 Gerrit-PatchSet: 1 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Mon, 02 Jul 2018 16:54:50 +0000 Gerrit-HasComments: No
