Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10704 )
Change subject: IMPALA-6625: Skip computing parquet conjuncts for non-Parquet scans ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/10704/11/tests/query_test/test_rows_availability.py File tests/query_test/test_rows_availability.py: http://gerrit.cloudera.org:8080/#/c/10704/11/tests/query_test/test_rows_availability.py@109 PS11, Line 109: matches = re.findall(r'([0-9]+h)?([0-9]+m)?([0-9]+s)?'\ > nit: long line Done http://gerrit.cloudera.org:8080/#/c/10704/11/tests/query_test/test_rows_availability.py@127 PS11, Line 127: milliseconds = int(float(matches[0][3][:-2])) : return hours * 60 * 60 * 1000 + minutes * 60 * 1000 + seconds * 1000 + milliseconds : : : > i think we can do away with not parsing this here since the method only ret Done -- To view, visit http://gerrit.cloudera.org:8080/10704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d6c26d42db090c8a15c602f6419ad6399c329e7 Gerrit-Change-Number: 10704 Gerrit-PatchSet: 12 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 02 Jul 2018 22:26:08 +0000 Gerrit-HasComments: Yes
