Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 )
Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query ...................................................................... Patch Set 7: (5 comments) Addressed the previous comments and did various cleanup work. http://gerrit.cloudera.org:8080/#/c/10415/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10415/6//COMMIT_MSG@18 PS6, Line 18: Added tests for various permutations for CPU_LIMIT_S and > Something I noticed after playing around: How about we rename this to have Done http://gerrit.cloudera.org:8080/#/c/10415/6/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/10415/6/be/src/service/impala-server.cc@1940 PS6, Line 1940: if (session_timeout <= 0) return; Fixed the null coordinator dereference and added a cancellation test that exercises the new code path. http://gerrit.cloudera.org:8080/#/c/10415/6/be/src/service/impala-server.cc@1970 PS6, Line 1970: is(); > This comment applies to my previous work here, but "expired" is actually ki Done http://gerrit.cloudera.org:8080/#/c/10415/6/be/src/service/impala-server.cc@1978 PS6, Line 1978: if (session_state.second->ref_count > 0) continue; > We still need to erase the event - now we have two copies of it so we've en Done http://gerrit.cloudera.org:8080/#/c/10415/6/be/src/service/impala-server.cc@1979 PS6, Line 1979: // A session closed by other means is in the process of being removed, and it's > nit: tabs Done -- To view, visit http://gerrit.cloudera.org:8080/10415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c6015e21da684bb9f33e236d71309dd4c178a20 Gerrit-Change-Number: 10415 Gerrit-PatchSet: 7 Gerrit-Owner: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Jul 2018 19:07:03 +0000 Gerrit-HasComments: Yes
