Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 )
Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/10855/2/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/10855/2/be/src/runtime/query-state.cc@263 PS2, Line 263: serialize_status.ok() Need a test case for serialization failure. May be global debug action is useful ? http://gerrit.cloudera.org:8080/#/c/10855/2/be/src/runtime/query-state.cc@303 PS2, Line 303: !RpcMgr::IsServerTooBusy(rpc_controller)) Need a test case for this. http://gerrit.cloudera.org:8080/#/c/10855/2/be/src/service/control-service.cc File be/src/service/control-service.cc: http://gerrit.cloudera.org:8080/#/c/10855/2/be/src/service/control-service.cc@107 PS2, Line 107: (UNLIKELY(!deserialize_status.ok()) Need a test case for deserialization error. -- To view, visit http://gerrit.cloudera.org:8080/10855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7638583b433dcac066b87198e448743d90415ebe Gerrit-Change-Number: 10855 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Jul 2018 22:30:11 +0000 Gerrit-HasComments: Yes
