Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 )
Change subject: IMPALA-3040: Remove cache directives during background partition dropping ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/10792/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10792/3//COMMIT_MSG@7 PS3, Line 7: during background partition dropping may be say external table drops? http://gerrit.cloudera.org:8080/#/c/10792/3//COMMIT_MSG@9 PS3, Line 9: Add some context about what happens when it is dropped from Hive. http://gerrit.cloudera.org:8080/#/c/10792/3//COMMIT_MSG@13 PS3, Line 13: Could you add a test for this in test_hdfs_caching? http://gerrit.cloudera.org:8080/#/c/10792/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10792/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1158 PS3, Line 1158: * HdfsPartition that was dropped or null if the partition does not exist. Update that this drops the cache directive if its cached. http://gerrit.cloudera.org:8080/#/c/10792/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1191 PS3, Line 1191: if (partition.isMarkedCached()) { I think this should only run on the Catalog server? http://gerrit.cloudera.org:8080/#/c/10792/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1193 PS3, Line 1193: HdfsCachingUtil.removePartitionCacheDirective(partition); Do we need to remove a similar check from CatalogOpEx#alterTableDropPartition()? No point in doing it twice. -- To view, visit http://gerrit.cloudera.org:8080/10792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7701a499405e961456adea63f3592b43bd69170 Gerrit-Change-Number: 10792 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Jul 2018 22:39:48 +0000 Gerrit-HasComments: Yes
