Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24536 )
Change subject: POC IMPALA-15162: Add GEOMETRY column support for Iceberg and Parquet ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/24536/5/be/src/exec/parquet/hdfs-parquet-table-writer.cc File be/src/exec/parquet/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/24536/5/be/src/exec/parquet/hdfs-parquet-table-writer.cc@224 PS5, Line 224: !type().IsGeometryType(); A comment like the one above (Min/max statistics are meaningless for geometric columns...) could be helpful here. http://gerrit.cloudera.org:8080/#/c/24536/5/be/src/exec/parquet/parquet-metadata-utils.cc File be/src/exec/parquet/parquet-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/24536/5/be/src/exec/parquet/parquet-metadata-utils.cc@471 PS5, Line 471: !col_type.IsBinaryType() Not directly related to this change, but wouldn't col_type.IsPlainStringType() be better here? -- To view, visit http://gerrit.cloudera.org:8080/24536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32d8c12a6b71708646fbfc06a6dd8f7aaf4f5e6b Gerrit-Change-Number: 24536 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 15 Jul 2026 08:14:50 +0000 Gerrit-HasComments: Yes
