Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/24218 )
Change subject: IMPALA-14912: Calcite Planner: Fix date string parsing ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/24218/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java: http://gerrit.cloudera.org:8080/#/c/24218/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java@219 PS10, Line 219: return new AnalyzedFunctionCallExpr(fn, params, Type.STRING); If the params.get(0) is not a string and return a valid Expr but UNHEX only supports string arguments according to the defined syntax.. so should we not just return null in that case ? I may be missing the the reasoning. If there's a valid reason, you could add it as a comment in the code too. -- To view, visit http://gerrit.cloudera.org:8080/24218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia08071193f86423a0e548c6b6690993afdad6272 Gerrit-Change-Number: 24218 Gerrit-PatchSet: 10 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 15 Jul 2026 23:17:59 +0000 Gerrit-HasComments: Yes
