Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24579 )
Change subject: IMPALA-15139: Support DELTA_LENGTH_BYTE_ARRAY Parquet encoding ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24579/2/be/src/exec/parquet/parquet-delta-length-byte-array-decoder.cc File be/src/exec/parquet/parquet-delta-length-byte-array-decoder.cc: http://gerrit.cloudera.org:8080/#/c/24579/2/be/src/exec/parquet/parquet-delta-length-byte-array-decoder.cc@73 PS2, Line 73: total_data_bytes > data_len > It's a basic integrity check. total_data_bytes is computed from the decoded What I mean is, what happens if total_data_bytes < data_len, but "actual lengths section size" + total_data_bytes > data_len? Will you not eventually access memory outside of the buffer through data_? Isn't it better to get the actual lengths section size through len_decoder.reader_.bytes_left()? -- To view, visit http://gerrit.cloudera.org:8080/24579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e4395fa30cd7fb2c89ef5a2b16b043d4de60b52 Gerrit-Change-Number: 24579 Gerrit-PatchSet: 3 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 16 Jul 2026 06:10:58 +0000 Gerrit-HasComments: Yes
