Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10876 )
Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10876/2/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/10876/2/shell/impala_shell.py@1147 PS2, Line 1147: nit: our convention is to use 2 space indentation http://gerrit.cloudera.org:8080/#/c/10876/2/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/10876/2/tests/shell/test_shell_interactive.py@658 PS2, Line 658: without closing quotation I noticed that shlex also throws a ValueError for "No escaped character". Can you add a test case here for that. The following statement is enough to trigger that error: "with v as (select 1) \;" -- To view, visit http://gerrit.cloudera.org:8080/10876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb1e9238ac67b8ad3b2caa1748a18b04f384802d Gerrit-Change-Number: 10876 Gerrit-PatchSet: 2 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Comment-Date: Fri, 06 Jul 2018 01:05:41 +0000 Gerrit-HasComments: Yes
