Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24422 )
Change subject: IMPALA-15081: Add ISO timestamp filters ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/24422/5/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/24422/5/be/src/util/impala-profile-tool.cc@338 PS5, Line 338: if (!ParseTimezoneAwareTime(FLAGS_min_time, TimeFilterBound::MIN, &filters->min)) { > Why are we writing our own timezone parsing? Boost provides this. Fixed in PS6. The calendar/time value and UTC offset are now parsed with Boost.Date_Time. The existing suffix forms and millisecond-bound rounding are preserved, with canonical validation to reject malformed timestamps that Boost would otherwise normalize. -- To view, visit http://gerrit.cloudera.org:8080/24422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c43e7535db48518b7d9dd0cbb87398e639c3b72 Gerrit-Change-Number: 24422 Gerrit-PatchSet: 5 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 16 Jul 2026 15:41:29 +0000 Gerrit-HasComments: Yes
