Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24453 )
Change subject: IMPALA-15096: Do not escape raw text profiles ...................................................................... IMPALA-15096: Do not escape raw text profiles Text profiles downloaded from the WebUI are served through raw_text.tmpl after setting Webserver::ENABLE_RAW_HTML_KEY. The template still used escaped Mustache substitution, so profile text with characters such as '<', '>', and apostrophes was downloaded with HTML entities. Render contents unescaped only when __raw__ is present. This preserves escaped output for non-raw users of the template. Add tests for raw and non-raw rendering. Update WebUI profile download tests, including LDAP coverage, to expect raw text from /query_profile_plain_text. Testing: - git diff --check asf-gerrit/master..HEAD - python3 -m py_compile tests/webserver/test_web_pages.py tests/custom_cluster/test_web_pages.py - python3 bin/jenkins/critique-gerrit-review.py --dryrun - Verified html.unescape(rf_profile_web.txt) matches rf_profile.txt using the IMPALA-15096 attachments - Ran be/build/latest/util/webserver-test with a gtest filter for RawTextTemplateDoesNotEscapeRawContents and RawTextTemplateEscapesNonRawContents Assisted-by: GPT-5 (Codex) Change-Id: I07965b7c550af6d136e4c343da84f77374e236ed Reviewed-on: http://gerrit.cloudera.org:8080/24453 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/util/webserver-test.cc M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java M tests/custom_cluster/test_web_pages.py M tests/webserver/test_web_pages.py M www/raw_text.tmpl 5 files changed, 66 insertions(+), 11 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I07965b7c550af6d136e4c343da84f77374e236ed Gerrit-Change-Number: 24453 Gerrit-PatchSet: 7 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
