Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default ...................................................................... Patch Set 6: Code-Review+2 (2 comments) as there are no comments from others, upgrading to +2 left 2 nits about not too useful comments http://gerrit.cloudera.org:8080/#/c/24543/6/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java: http://gerrit.cloudera.org:8080/#/c/24543/6/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@348 PS6, Line 348: // Alias the collection ref so that the 'int_array' column expanded by 'select *' : // (EXPAND_COMPLEX_TYPES defaults to true) does not collide with the 'c.int_array' : // collection alias. Is this comment really useful? http://gerrit.cloudera.org:8080/#/c/24543/6/testdata/workloads/functional-planner/queries/PlannerTest/empty.test File testdata/workloads/functional-planner/queries/PlannerTest/empty.test: http://gerrit.cloudera.org:8080/#/c/24543/6/testdata/workloads/functional-planner/queries/PlannerTest/empty.test@609 PS6, Line 609: # Alias the collection ref so that the c_orders array column expanded by 'select *' : # (EXPAND_COMPLEX_TYPES defaults to true) does not collide with the c.c_orders : # collection alias ("Duplicate table alias"). is this comment really useful? -- To view, visit http://gerrit.cloudera.org:8080/24543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2 Gerrit-Change-Number: 24543 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 17 Jul 2026 14:58:11 +0000 Gerrit-HasComments: Yes
