Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23848 )
Change subject: IMPALA-14942: [tools] Impala devcontainer ...................................................................... Patch Set 33: (7 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23848/33/.devcontainer-build/build-devcontainer.sh File .devcontainer-build/build-devcontainer.sh: http://gerrit.cloudera.org:8080/#/c/23848/33/.devcontainer-build/build-devcontainer.sh@64 PS33, Line 64: echo "Unsupported platform '${PLATFORM}'. Allowed values are 'x86_64', 'arm64', and 'aarch64'." >&2 line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/23848/33/.devcontainer-build/build-devcontainer.sh@86 PS33, Line 86: echo "[WARN] Script failed (exit code: ${exit_code}); keeping docker builder '${DOCKER_BUILDER}'." >&2 line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/23848/33/.devcontainer-build/build-devcontainer.sh@103 PS33, Line 103: IMPALA_CMAKE_VERSION="$(grep 'export IMPALA_CMAKE_VERSION=' "${IMPALA_HOME}/bin/impala-config.sh" | cut -d'=' -f2)" line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/23848/33/.devcontainer-build/build-devcontainer.sh@104 PS33, Line 104: IMPALA_GCC_VERSION="$(grep 'export IMPALA_GCC_VERSION=' "${IMPALA_HOME}/bin/impala-config.sh" | cut -d'=' -f2)" line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/23848/33/.devcontainer/regen-ssh-keys.sh File .devcontainer/regen-ssh-keys.sh: http://gerrit.cloudera.org:8080/#/c/23848/33/.devcontainer/regen-ssh-keys.sh@38 PS33, Line 38: -C "Impala-devcontainer-$(date +'%Y-%m-%d_%H:%M:%S') - Impala devcontainer '${HOSTNAME}' created '$(date)'" \ line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/23848/33/.devcontainer/set-tz-locale.sh File .devcontainer/set-tz-locale.sh: http://gerrit.cloudera.org:8080/#/c/23848/33/.devcontainer/set-tz-locale.sh@29 PS33, Line 29: echo "[INFO] No timezone file found at '/.impala-devcontainer-tz'. Skipping timezone configuration." line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/23848/33/.devcontainer/set-tz-locale.sh@37 PS33, Line 37: echo "[INFO] No locale file found at '/.impala-devcontainer-locale'. Skipping locale configuration." line too long (102 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6aa834494003619fcdfbd98f3bfc7c74d3e1554c Gerrit-Change-Number: 23848 Gerrit-PatchSet: 33 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gowthami Bisati <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sun, 19 Jul 2026 12:32:29 +0000 Gerrit-HasComments: Yes
