Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24363 )
Change subject: IMPALA-14981: Add operator reconciler packaging ...................................................................... Patch Set 35: (2 comments) http://gerrit.cloudera.org:8080/#/c/24363/35/operator/impala-operator/main.py File operator/impala-operator/main.py: http://gerrit.cloudera.org:8080/#/c/24363/35/operator/impala-operator/main.py@38 PS35, Line 38: DEFAULT_LDAP_VALUES_FILE = os.getenv( DEFAULT_LDAP_VALUES_FILE fallback points to values-impala-ldap-example.yaml, but _ensure_ldap() installs openldap/openldap. Should this fallback be values-ldap-example.yaml (OpenLDAP chart values) to avoid misconfiguration when env overrides are absent? http://gerrit.cloudera.org:8080/#/c/24363/35/operator/impala-operator/main.py@244 PS35, Line 244: def _delete_release(release: str, namespace: str, logger) -> None: _delete_release() currently swallows all helm uninstall failures (already absent and real failures are treated the same). Could we only ignore “release not found” and re-raise other errors so reconcile/finalizer retries instead of silently leaving stale releases? -- To view, visit http://gerrit.cloudera.org:8080/24363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b66e32b00724221ead2f4975802a26b2be7e248 Gerrit-Change-Number: 24363 Gerrit-PatchSet: 35 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Comment-Date: Mon, 20 Jul 2026 20:32:27 +0000 Gerrit-HasComments: Yes
