Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24558 )
Change subject: IMPALA-15019: Avoid materializing non-projected filtered partition column. ...................................................................... Patch Set 15: Code-Review+1 (6 comments) LGTM. Just have some minor comments. http://gerrit.cloudera.org:8080/#/c/24558/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24558/15//COMMIT_MSG@20 PS15, Line 20: filteredOnlyInputRefs nit: "filterOnlyInputRefs" http://gerrit.cloudera.org:8080/#/c/24558/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaFilterRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaFilterRel.java: http://gerrit.cloudera.org:8080/#/c/24558/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaFilterRel.java@90 PS15, Line 90: ImmutableBitSet.Builder filterOnlyBuilder = ImmutableBitSet.builder(); this is unused now http://gerrit.cloudera.org:8080/#/c/24558/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java: http://gerrit.cloudera.org:8080/#/c/24558/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@187 PS15, Line 187: ParentPlanRelContext context) throws ImpalaException { not used now http://gerrit.cloudera.org:8080/#/c/24558/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@229 PS15, Line 229: */ Should we remove this? http://gerrit.cloudera.org:8080/#/c/24558/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@371 PS15, Line 371: nit: just need one blank line http://gerrit.cloudera.org:8080/#/c/24558/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java: http://gerrit.cloudera.org:8080/#/c/24558/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@148 PS15, Line 148: builder.setFilterCondition(mapInputRefs(context.filterCondition_, getProjects())); This duplicates L129. Can we remove this? -- To view, visit http://gerrit.cloudera.org:8080/24558 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I902dc625963321aff57e5c05af3d1137c06aa882 Gerrit-Change-Number: 24558 Gerrit-PatchSet: 15 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Tue, 21 Jul 2026 06:29:29 +0000 Gerrit-HasComments: Yes
