Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24572 )

Change subject: IMPALA-15171: Null out Iceberg delete file path slot after the 
join
......................................................................


Patch Set 4:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24572/4/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/24572/4/tests/query_test/test_iceberg.py@2872
PS4, Line 2872: v
flake8: U100 Unused argument 'vector'


http://gerrit.cloudera.org:8080/#/c/24572/4/tests/query_test/test_iceberg.py@2885
PS4, Line 2885: E
flake8: F841 local variable 'EXPECTED_SELF_JOIN_COUNT' is assigned to but never 
used


http://gerrit.cloudera.org:8080/#/c/24572/4/tests/query_test/test_iceberg.py@2889
PS4, Line 2889: M
flake8: F841 local variable 'MAX_BYTES' is assigned to but never used



--
To view, visit http://gerrit.cloudera.org:8080/24572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e662cb6a98dd3e687185d384731d6be45f91b94
Gerrit-Change-Number: 24572
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Comment-Date: Wed, 22 Jul 2026 13:21:03 +0000
Gerrit-HasComments: Yes

Reply via email to