Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24154 )
Change subject: IMPALA-14852 Codegen tuple TryDeepCopy for Broadcast Exchange ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/24154/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24154/14//COMMIT_MSG@29 PS14, Line 29: Can you add some codegen stats like in https://gerrit.cloudera.org/#/c/24089/ ? http://gerrit.cloudera.org:8080/#/c/24154/14/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: http://gerrit.cloudera.org:8080/#/c/24154/14/be/src/runtime/row-batch.h@361 PS14, Line 361: IR_ALWAYS_INLINE Should be no inline, right? -- To view, visit http://gerrit.cloudera.org:8080/24154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa43e949c63db047717104dbbe42d47f94ebf2d0 Gerrit-Change-Number: 24154 Gerrit-PatchSet: 14 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2026 08:56:16 +0000 Gerrit-HasComments: Yes
