Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24418 )
Change subject: IMPALA-15082: Add VSCode Settings and Launch Configs ...................................................................... Patch Set 18: (4 comments) http://gerrit.cloudera.org:8080/#/c/24418/18/.vscode-defaults/settings.json File .vscode-defaults/settings.json: http://gerrit.cloudera.org:8080/#/c/24418/18/.vscode-defaults/settings.json@30 PS18, Line 30: 16G Some laptop just has 16GB RAM. Do we really need 16GB here? Or do you see severe GC issues when using smaller heap size like 8GB? http://gerrit.cloudera.org:8080/#/c/24418/18/.vscode-defaults/settings.json@103 PS18, Line 103: "C_Cpp.exclusionPolicy": "checkFolders", How about adding the compile commands? "C_Cpp.default.compileCommands": "${env:IMPALA_HOME}/compile_commands.json" http://gerrit.cloudera.org:8080/#/c/24418/18/.vscode-defaults/settings.json@162 PS18, Line 162: }, Can we add 11050 which is the HiveServer2 port? http://gerrit.cloudera.org:8080/#/c/24418/18/.vscode-defaults/settings.json@208 PS18, Line 208: "scoped_allocator": "cpp", "shared_mutex": "cpp", "sstream": "cpp", "stdexcept": "cpp", "streambuf": "cpp", "thread": "cpp", "typeindex": "cpp", "typeinfo": "cpp", It seems hard to maintain this. Do we need to add all header names in the list? -- To view, visit http://gerrit.cloudera.org:8080/24418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98e6966d83fdaaedda867a37b42725616d3b9216 Gerrit-Change-Number: 24418 Gerrit-PatchSet: 18 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gowthami Bisati <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Jiyoung Yoo <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 29 Jul 2026 00:58:47 +0000 Gerrit-HasComments: Yes
