Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 )
Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10615/2/bin/run_clang_tidy.sh File bin/run_clang_tidy.sh: http://gerrit.cloudera.org:8080/#/c/10615/2/bin/run_clang_tidy.sh@57 PS2, Line 57: run-clang-tidy.py -quiet -header-filter "${PIPE_DIRS%?}" -j"${CORES}" ${DIRS} 2> /dev/null What if something catastrophically bad happens with the script that is orthogonal to tidiness, like not having the right python installed or a parse error in the python in the script? Can we capture that stderr output for later diagnosis? What about UHOH=$(mktemp) if ! command 2>"${UHOH}" then cat "${UHOH}" >&2 exit 1 fi -- To view, visit http://gerrit.cloudera.org:8080/10615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63c46a7d57295eba38fac8ab49c7a15d2802df1d Gerrit-Change-Number: 10615 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Fri, 06 Jul 2018 21:30:46 +0000 Gerrit-HasComments: Yes
