Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24552 )
Change subject: IMPALA-15165: Add minimal C++ WKB serialization support ...................................................................... Patch Set 10: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24552/10/be/src/exprs/geo/wkb-serialization.cc File be/src/exprs/geo/wkb-serialization.cc: http://gerrit.cloudera.org:8080/#/c/24552/10/be/src/exprs/geo/wkb-serialization.cc@96 PS10, Line 96: bool ReadWkbLineString(const uint8_t* data, int len, linestring2d& result, bool big_endian) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24552/10/be/src/exprs/geo/wkb-serialization.cc@108 PS10, Line 108: bool ReadWkbMultiPoint(const uint8_t* data, int len, multipoint2d& result, bool big_endian) { line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24552 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d5b2ac5d584e3de7712d8471acbc07d743a4de2 Gerrit-Change-Number: 24552 Gerrit-PatchSet: 10 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 31 Jul 2026 16:25:48 +0000 Gerrit-HasComments: Yes
