Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22094 )
Change subject: IMPALA-13533: Calcite CTE backend ...................................................................... Patch Set 61: (1 comment) http://gerrit.cloudera.org:8080/#/c/22094/61/be/src/exec/cte-producer-node.cc File be/src/exec/cte-producer-node.cc: http://gerrit.cloudera.org:8080/#/c/22094/61/be/src/exec/cte-producer-node.cc@91 PS61, Line 91: RETURN_IF_CANCELLED(state); : unique_ptr<RowBatch> child_batch(new RowBatch( : child(0)->row_desc(), state->batch_size(), mem_tracker())); : RETURN_IF_ERROR(children_[0]->GetNext(state, child_batch.get(), &eos)); : VLOG_PROGRESS << "Adding " << child_batch->num_rows() : << " rows to CTE exchange " << name_ << " in " << label(); : // Add all row batches, even if empty, to avoid freeing the tuple data pool. : if (needs_batch_deep_copy_ && child_batch->num_rows() > 0) { : unique_ptr<RowBatch> copy( : new RowBatch(child(0)->row_desc(), child_batch->num_rows(), mem_tracker())); : child_batch->DeepCopyTo(copy.get()); : RETURN_IF_ERROR(exchanger_->Push(std::move(copy))); : } else { : DCHECK(!child_batch->needs_deep_copy() || child_batch->num_rows() == 0); : RETURN_IF_ERROR(exchanger_->Push(std::move(child_batch))); : } > Nit: In the exec summary, the #Rows for the CTE Producer is 0. I think it m Done -- To view, visit http://gerrit.cloudera.org:8080/22094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48f16d495d4b37be97e6a913f0eb5b94d70e199a Gerrit-Change-Number: 22094 Gerrit-PatchSet: 61 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 13 Aug 2026 22:35:51 +0000 Gerrit-HasComments: Yes
