Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24570 )
Change subject: IMPALA-12675: Set PARQUET_ANNOTATE_STRINGS_UTF8 to true by default and turn on validation ...................................................................... Patch Set 15: (3 comments) Looks good in general, my main high level question is CHAR/VARCHAR handling. http://gerrit.cloudera.org:8080/#/c/24570/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24570/15//COMMIT_MSG@23 PS15, Line 23: CHAR/VARCHAR (always text) What is the reason for not validating these? http://gerrit.cloudera.org:8080/#/c/24570/14/be/src/exec/parquet/hdfs-parquet-table-writer.cc File be/src/exec/parquet/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/24570/14/be/src/exec/parquet/hdfs-parquet-table-writer.cc@940 PS14, Line 940: No UNLIKELY hint: for a : // UTF-8-annotated STRING column (the default, and always for Iceberg) this is taken on : // nearly every row. Doesn't seem very useful info. Generally comments look a bit verbose, I assume because of Claude. http://gerrit.cloudera.org:8080/#/c/24570/15/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/24570/15/tests/query_test/test_scanners.py@940 PS15, Line 940: get_parquet_metadata There is also get_parquet_metadata_from_hdfs_folder, why not use that? -- To view, visit http://gerrit.cloudera.org:8080/24570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia95bcba978863ffb5d603fdf81bb2c75ba06f7da Gerrit-Change-Number: 24570 Gerrit-PatchSet: 15 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2026 10:21:35 +0000 Gerrit-HasComments: Yes
