Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10895 )
Change subject: IMPALA-7129: Fixing path to UBSAN suppressions. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10895/2/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10895/2/be/CMakeLists.txt@118 PS2, Line 118: SET(CXX_FLAGS_UBSAN "${CXX_FLAGS_UBSAN} -DUNDEFINED_SANITIZER_SUPPRESSIONS=$ENV{IMPALA_HOME}/bin/ubsan-suppressions.txt") This line's long. I made it better than PS1, but if we think it's better to split these, happy to try it. The only example I found of line splitting was on line 111 above here. Whereas we also have long lines. My preference is to leave it long, but I'm happy to adjust. http://gerrit.cloudera.org:8080/#/c/10895/2/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/10895/2/be/src/common/init.cc@306 PS2, Line 306: #define STRINGIFY(a) STRINGIFY_INTERNAL(a) I'm trying to avoid using Substitute() or any other functions here so that this is absolutely obviously working. I also found BOOST_PP_STRINGIZE but that would pull in more boost. If there's a more canonical way to pull in a string constant from a preprocessor definition, please let me know. -- To view, visit http://gerrit.cloudera.org:8080/10895 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5295c2d1bddbea585a761b85a51eadecf10d191d Gerrit-Change-Number: 10895 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Mon, 09 Jul 2018 22:06:28 +0000 Gerrit-HasComments: Yes
