Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10858 )
Change subject: IMPALA-7027: Mulitple varchar cast fails with distinct ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10858/4/fe/src/main/java/org/apache/impala/analysis/StatementBase.java File fe/src/main/java/org/apache/impala/analysis/StatementBase.java: http://gerrit.cloudera.org:8080/#/c/10858/4/fe/src/main/java/org/apache/impala/analysis/StatementBase.java@115 PS4, Line 115: // If varchar is longer length, the recasting is unnecessary. > It doesn't feel right putting this logic in StatementBase and the logic see It can either go here, or have a specific check in base Expr.castTo next to the specific isDecimal check. Where it is, it short circuits several additional checks. -- To view, visit http://gerrit.cloudera.org:8080/10858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fa5890eaa89787645c7d3d2eef976f54a34e7c0 Gerrit-Change-Number: 10858 Gerrit-PatchSet: 4 Gerrit-Owner: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Comment-Date: Tue, 10 Jul 2018 14:24:34 +0000 Gerrit-HasComments: Yes
