Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24645 )
Change subject: IMPALA-15230: Restrict the check for "tests" to the jar name proper ...................................................................... IMPALA-15230: Restrict the check for "tests" to the jar name proper ...during Docker image builds. The context builder script that runs during Impala Docker image builds screens out test jars by checking the file name for the "tests" substring for certain jars. This check is too aggressive: it triggers if any part of the full pathname, even an enclosing directory name contains "tests", breaking the container build. This patch constrains the check to the jar name itself by splitting off the basename of the jar before checking. It also converts the assertion into an Exception with a message so that the check is not skipped if the script happens to run in Python's optimized mode. Change-Id: Idb783e3c7dfc064d7a6ed6804e429393a0de3cbf Reviewed-on: http://gerrit.cloudera.org:8080/24645 Reviewed-by: Joe McDonnell <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Michael Smith <[email protected]> --- M docker/setup_build_context.py 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Joe McDonnell: Looks good to me, but someone else must approve Impala Public Jenkins: Verified Michael Smith: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/24645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idb783e3c7dfc064d7a6ed6804e429393a0de3cbf Gerrit-Change-Number: 24645 Gerrit-PatchSet: 3 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
