Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24217 )
Change subject: IMPALA-14911: Calcite planner: Fix boolean to numeric comparison ...................................................................... Patch Set 2: (1 comment) One question about DECIMAL in the new common-type rule. http://gerrit.cloudera.org:8080/#/c/24217/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeCoercionImpl.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeCoercionImpl.java: http://gerrit.cloudera.org:8080/#/c/24217/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeCoercionImpl.java@123 PS2, Line 123: if (SqlTypeUtil.isBoolean(type1) && SqlTypeUtil.isNumeric(type2)) { SqlTypeUtil.isNumeric() covers DECIMAL too, and that is the one numeric family Impala keeps out: DefaultCompatibility.java:50 sets BOOLEAN x DECIMAL to INVALID_TYPE, so "select count(*) from functional.decimal_tbl where d1 > sleep(100)" gets "operands of type DECIMAL(9,0) and BOOLEAN are not comparable" from the original planner. With this override the Calcite side settles on DECIMAL and casts the boolean to it - and there is no such cast in the backend (decimal-operators.h lists CastToDecimalVal from the int/float/string types and CastToBooleanVal, nothing from BOOLEAN), so the query fails later with a different error instead. Would it be worth skipping DECIMAL here, so both planners reject the same thing? A negative case in calcite.test would pin it down. -- To view, visit http://gerrit.cloudera.org:8080/24217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I764dcbd2fd0d1323bfb964ed91d94cd3def594c0 Gerrit-Change-Number: 24217 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sun, 23 Aug 2026 14:44:21 +0000 Gerrit-HasComments: Yes
