Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 )
Change subject: IMPALA-4669: [KSECURITY] Add security library to build ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/10759/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10759/8//COMMIT_MSG@13 PS8, Line 13: The original commit message is below: > I tried to keep the commit messages the same. The alternative seems to be r I see. This patch along with the other 2 patches for rpc and util directories aim to get the kudu code to compile in Impala so they seem to be different from other cherry-picks. This patch has evolved since the original commit because we have pushed some of the changes into the Kudu code base. So, may make sense to me to actually document what we do in this patch. I find the the original commit message stale now as this patch doesn't actually do certain things claimed in the commit message. What do others think ? -- To view, visit http://gerrit.cloudera.org:8080/10759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab51d887f5e771ad62eeddc14b9c47f42c3130d Gerrit-Change-Number: 10759 Gerrit-PatchSet: 8 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Tue, 10 Jul 2018 19:52:36 +0000 Gerrit-HasComments: Yes
