Hello Zoltan Borok-Nagy, Peter Rozsa, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24682
to look at the new patch set (#3).
Change subject: IMPALA-13832: Finalize REST catalog INSERT
......................................................................
IMPALA-13832: Finalize REST catalog INSERT
Enable INSERT INTO for Iceberg tables loaded from named REST catalogs.
Carry the opaque catalog name through DML finalization and reload the
target from the same provider. This keeps routing correct with CatalogD
or multiple REST catalogs without exposing endpoints or credentials.
Reuse the shared Iceberg finalizer and planning-time table UUID.
Existing HMS/CatalogD tables retain their current finalization route.
REST catalog writes remain limited to INSERT INTO.
Testing:
- Java, generated Thrift, impalad, catalogd and statestored builds
- Analyzer, provider routing, UUID and cleanup tests
- Standalone, mixed and multi-provider REST INSERT
- Known and unknown commit failure cleanup
- Fixture ownership, qualified paths and shutdown cleanup
Change-Id: I7d17216fb8d12e5bd007b93cb9b3bc153438213b
Assisted-by: gpt-5.6-sol (OpenAI Codex)
---
M be/src/service/client-request-state.cc
M be/src/service/frontend.cc
M be/src/service/frontend.h
M common/thrift/CatalogService.thrift
M common/thrift/Query.thrift
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/MergeStmt.java
M fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java
M fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergRESTCatalog.java
M fe/src/main/java/org/apache/impala/catalog/local/IcebergMetaProvider.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M
fe/src/main/java/org/apache/impala/service/catalogmanager/FeCatalogManager.java
M fe/src/main/java/org/apache/impala/service/catalogmanager/LocalImpl.java
M fe/src/main/java/org/apache/impala/service/catalogmanager/TestImpl.java
M fe/src/main/java/org/apache/impala/util/DebugUtils.java
A fe/src/test/java/org/apache/impala/analysis/AnalyzerCapabilityTest.java
A fe/src/test/java/org/apache/impala/service/IcebergRestDmlOperationTest.java
A fe/src/test/java/org/apache/impala/service/catalogmanager/LocalImplTest.java
M fe/src/test/java/org/apache/impala/util/DebugUtilsTest.java
M
java/iceberg-rest-catalog-test/src/main/java/org/apache/iceberg/rest/IcebergRestCatalogTest.java
M testdata/bin/run-iceberg-rest-server.sh
M testdata/configs/catalog_configs/iceberg_rest_config/rest.properties
M testdata/configs/catalog_configs/multicatalog_rest_config/rest-1.properties
M testdata/configs/catalog_configs/multicatalog_rest_config/rest-2.properties
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-multicatalog.test
M tests/common/iceberg_rest_server.py
M tests/custom_cluster/test_iceberg_rest_catalog.py
33 files changed, 845 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/24682/3
--
To view, visit http://gerrit.cloudera.org:8080/24682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d17216fb8d12e5bd007b93cb9b3bc153438213b
Gerrit-Change-Number: 24682
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
