Aleksandr Efimov has posted comments on this change. (
http://gerrit.cloudera.org:8080/24260 )
Change subject: IMPALA-14946: Catch "trunc" error within Calcite planner
......................................................................
Patch Set 6: Code-Review+1
Both new exprs.test cases pass under the Calcite planner as well as the
original one - the CATCH string matches the IllegalArgumentException text. The
section just above them, dayofyear(trunc('2014-11-11', string_col)) with
"Invalid Truncate Unit: 0", answers "trunc() must be called with a constant
second argument" under Calcite, so it will need attention when exprs.test joins
that build.
--
To view, visit http://gerrit.cloudera.org:8080/24260
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I766c138fae027ba0d919daa5cce38dc93d7144d1
Gerrit-Change-Number: 24260
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Tue, 25 Aug 2026 19:32:33 +0000
Gerrit-HasComments: No
