Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24268 )
Change subject: IMPALA-14910: Calcite planner: support expressions in limit clause ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/24268/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/24268/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@208 PS5, Line 208: private static RelNode processSimpleNode(RelNode relNode, List<RelNode> inputs, processSimpleNode also serves CTEPRODUCER and SEQUENCE, and the cast to LogicalSort is unconditional now. I could not reach it - CTE nodes are built in runCTEProgram, after coerceNodes, and a query with cte_threshold=1 plans fine on this patch - so this is about the next person rather than today. Would renaming it back to processSortNode, and leaving the copy() path for the other two, keep that clear? -- To view, visit http://gerrit.cloudera.org:8080/24268 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic01a0144671485156654e7685d0d5816fa743f9d Gerrit-Change-Number: 24268 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 25 Aug 2026 16:13:36 +0000 Gerrit-HasComments: Yes
