Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24747 )

Change subject: IMPALA-15301: Export Impala's explicit cast as a Substrait cast
......................................................................


Patch Set 2:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24747/2/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/SubstraitPlanExporterTest.java
File 
java/calcite-planner/src/test/java/org/apache/impala/calcite/service/SubstraitPlanExporterTest.java:

http://gerrit.cloudera.org:8080/#/c/24747/2/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/SubstraitPlanExporterTest.java@358
PS2, Line 358:     
assertEquals(io.substrait.proto.Expression.Cast.FailureBehavior.FAILURE_BEHAVIOR_RETURN_NULL,
line too long (97 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7523bc5ebd6239e92dc817bbe521920121ec8b2b
Gerrit-Change-Number: 24747
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 25 Aug 2026 23:57:27 +0000
Gerrit-HasComments: Yes

Reply via email to