Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24741 )
Change subject: IMPALA-15296: Export the seam plan to Substrait ...................................................................... Patch Set 7: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24741/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/SubstraitOperatorMappings.java File java/calcite-planner/src/test/java/org/apache/impala/calcite/service/SubstraitOperatorMappings.java: http://gerrit.cloudera.org:8080/#/c/24741/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/SubstraitOperatorMappings.java@31 PS7, Line 31: import io.substrait.isthmus.SubstraitRelVisitor; unused import: io.substrait.isthmus.SubstraitRelVisitor http://gerrit.cloudera.org:8080/#/c/24741/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/SubstraitPlanExporterTest.java File java/calcite-planner/src/test/java/org/apache/impala/calcite/service/SubstraitPlanExporterTest.java: http://gerrit.cloudera.org:8080/#/c/24741/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/service/SubstraitPlanExporterTest.java@412 PS7, Line 412: assertEquals(io.substrait.proto.Expression.Cast.FailureBehavior.FAILURE_BEHAVIOR_RETURN_NULL, line too long (97 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e7645e6d6af599af6ec3c53780d12935ab7efb Gerrit-Change-Number: 24741 Gerrit-PatchSet: 7 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 03:22:28 +0000 Gerrit-HasComments: Yes
