Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24657 )
Change subject: IMPALA-13534: Implement runtime filters on CTEs ...................................................................... Patch Set 22: (2 comments) http://gerrit.cloudera.org:8080/#/c/24657/22/be/src/exec/cte-consumer-node.cc File be/src/exec/cte-consumer-node.cc: http://gerrit.cloudera.org:8080/#/c/24657/22/be/src/exec/cte-consumer-node.cc@255 PS22, Line 255: if (!filter_ctxs_.empty()) { : if (!filters_waited_) { : filters_waited_ = true; : WaitForRuntimeFilters(state, filter_ctxs_); : } : FilterRowBatch(output_batch); : } > It would be nice to avoid the copy for the is_passthrough_ == false branch The memcpy for CopyRows on passthrough is pretty efficient, it does one bulk memcpy of the whole batch. It wasn't clear that breaking that up to check each row for runtime filters would be better. I don't think CTE consumers have conjuncts. So I think there's possible follow-up here, but they're not straight-forward. http://gerrit.cloudera.org:8080/#/c/24657/22/be/src/exec/cte-consumer-node.cc@285 PS22, Line 285: for (const FilterContext& ctx : filter_ctxs_) { : if (ctx.expr_eval != nullptr) ctx.expr_eval->Close(state); : } > https://github.com/apache/impala/commit/8f6fdc0f3910503556fc088cc4ef306ac5e I'll try to add it. -- To view, visit http://gerrit.cloudera.org:8080/24657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic877fb590187826f828da6a27bf274465c381e8e Gerrit-Change-Number: 24657 Gerrit-PatchSet: 22 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 17:45:03 +0000 Gerrit-HasComments: Yes
