Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24755 )
Change subject: IMPALA-15144: Fetch and store credentials from REST catalog ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24755/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/24755/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@910 PS2, Line 910: for (Credential cred : icebergTable.getCredentials()) { > Two facts and then it's yours and Zoltan's call. The file is documented as COPY TESTCASE is broken for Iceberg tables (IMPALA-12843), but users could still invoke it to dump metadata information about the tables, so I think the right call is to be defensive here, and not let credentials creep into diagnostic dumps. We should also add a comment here, because it's not trivial why we restrict it to DESCRIPTOR_ONLY. It would be nice to have a more generic mechanism for this, e.g. annotating thrift fields as sensitive and explicitly redacting them from logs/dumps. But it's out of the scope of this change. -- To view, visit http://gerrit.cloudera.org:8080/24755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d9c6e97e17fe8ad6304b49b07fd047cc2a3ffbe Gerrit-Change-Number: 24755 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 28 Aug 2026 07:12:30 +0000 Gerrit-HasComments: Yes
